Make sync version work on large messages, improve sync version using deasync #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shed, avoid spawn - very limited since it passes string to send using command-line
0xl3x1
approved these changes
Oct 13, 2016
Pull latest upstream changes and remove redundant require("child_process")
ghost
mentioned this pull request
|
@driverdan Any update on this? Any blockers that need to be addressed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend sync version using deasync, spawn is error prone - once message gets large (~150k) it crashes due to command-line limitations. With this fix the same code is used for both sync / async versions.